GrandOrgue / grandorgue

GrandOrgue software
Other
148 stars 39 forks source link

MIDI Signals on Shutdown of GrandOrgue #1896

Closed pipe-organ-enthusiast closed 2 months ago

pipe-organ-enthusiast commented 2 months ago

When terminating GrandOrgue, the MIDI events for the "ON" button in "Master Controls" should be sent AFTER MIDI events for the organ stops, divisionals, generals, etc. This is NOT happening. I'm still having my Novation Launchpads remain illuminated with the stop layout from my last used sampleset when I exit GrandOrgue.

larspalo commented 2 months ago

Fix of this issue was committed less than 5 days ago, test a more recent build like https://github.com/GrandOrgue/grandorgue/actions/runs/8838235975 until a new release is out.

pipe-organ-enthusiast commented 2 months ago

I successfully installed this build and tested it. It works exactly as expected. Thanks so much!

On Sat, Apr 27, 2024, 11:54 a.m. larspalo @.***> wrote:

Fix of this issue was committed less than 5 days ago, test a more recent build like https://github.com/GrandOrgue/grandorgue/actions/runs/8838235975 until a new release is out.

— Reply to this email directly, view it on GitHub https://github.com/GrandOrgue/grandorgue/issues/1896#issuecomment-2080956077, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFATKLMEML2X45GSWUMUPATY7PCZTAVCNFSM6AAAAABG4ATJR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBQHE2TMMBXG4 . You are receiving this because you authored the thread.Message ID: @.***>

oleg68 commented 2 months ago

Already fixed