search

GrandOrgue / grandorgue

GrandOrgue software
Other
148 stars 39 forks source link

Adding a tone balance voicing option #1902

Closed larspalo closed 1 month ago

larspalo commented 2 months ago

Resolves #1901.

As discussed in #1596 and #1882 there is a desire to have a voicing option that affects the tone balance between bass and treble.

This PR adds such a feature in the organ settings dialog. The user can set a value for tonal balance in the range of -100 to 100 where 0 is a default value and means that no filtering will take place. The set value will be converted to a frequency in the range of 20 to 16000 that will be the corner frequency for either a first order lowpass or a highpass filter. The relative strength of the lower and higher frequencies can thus be affected and as an effect of that the tone character can be changed.

oleg68 commented 1 month ago

@larspalo I'd prefer the first variant - displaying 0 at the pipe level among all other your variants. A predictable solution is better than unpredictable one.

larspalo commented 1 month ago

@oleg68 So, it's ok if I revert the two latest commits then?

oleg68 commented 1 month ago

@larspalo Yes, it would be better.

oleg68 commented 1 month ago

@larspalo When you merge this PR please select a 'Squash and merge' option forhaving only one commit in the master branch.