GrandOrgue / grandorgue

GrandOrgue software
Other
148 stars 39 forks source link

Added Midi event trigger for panic button and File/Exit menu #1909

Closed lupushortus closed 1 month ago

lupushortus commented 1 month ago

Resolves: #1807 Resolves: #1905 Setter class has two new virtual buttons, that provide MIDI access to panic button and exit function Implements Issues #1905 and #1807

oleg68 commented 1 month ago

@lupushortus

  1. Please remove any changes from the submodules/RtAudio submodule. They do not relate to this functionality.
  2. How a user can assign MIDI settings to these hidden buttons?
lupushortus commented 1 month ago

Hi @oleg68,

  1. I struggled merging/updating upstream branch into my fork/branch handling the submodule RtAudio correctly. After some forced pushes I integrated it cleanly. Sorry for the confusion.

  2. Regarding the hidden buttons: Go to menu Audio/Midi => MIDI Objects, there's a list of all MIDI elements available, search and select button Panic or Exit GrandOrgue, that appear with that change and press Configure button. Standard MIDI config dialogue will appear.

lupushortus commented 1 month ago

@lupushortus Could you add a changelog entry and a sescriprion of new setter elements to the help file?

Done

lupushortus commented 1 month ago

@lupushortus please add also the descriprion of Exit and of the new setter elements in the Setter elements section

Done, also added links to relevant items.