GrandOrgue / grandorgue

GrandOrgue software
Other
148 stars 39 forks source link

[Feature Request] Advanced Loading #1927

Open Mirejai opened 1 week ago

Mirejai commented 1 week ago

Hello, May I suggest to implement a new option « Advanced Loading... » in the File menu in order to have access to something like organ settings before loading the organ. It may be useful because when we load organ that require a lot of memory it would be appreciable to control if we want it to be 16 bit or 24 bit (as 16 bit require less memory) without changing the default settings in the general settings. We could also disable some samples we don’t need.

larspalo commented 1 week ago

@Mirejai This can quite easily already be "kind of" acomplished, even if it's perhaps not so obvious. If I ever need to do something like that (and don't want to change the general settings - which I usually do very frequently anyway) I just immediately click to abort the loading which triggers a dialog that states that not the whole organ was loaded as the load was aborted (quite right, as I just did that on purpose...). Then I enter the Organ settings dialog and adjust to my hearts content. When happy with the applied settings I reload the organ, and save it in the dialog that pops up, and wait for it to (re-)load to have the adjustments take effect.

Mirejai commented 1 week ago

@larspalo Thank you for your answer. I think it's not a very new-user-friendly way of doing this. Even if it can do the work, I think that adding an option to do it directly would be a small (but real) quality-of-life improvement.

oleg68 commented 1 week ago

Adjusting organ options every time when the organ is loaded is not a desired way. It is much better to modify the organ settings only once and save them. You already can do this with existing version. So I would not implement the fearure you requested.

вс, 23 июн. 2024 г., 11:13 Mirejai @.***>:

@larspalo https://github.com/larspalo Thank you for your answer. I think it's not a very new-user-friendly way of doing this. Even if it can do the work, I think that adding an option to do it directly would be a small (but real) quality-of-life improvement.

— Reply to this email directly, view it on GitHub https://github.com/GrandOrgue/grandorgue/issues/1927#issuecomment-2184842583, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYMXSXOI5FNYTPHIFPQVY3ZIZ7RZAVCNFSM6AAAAABJXNFYOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBUHA2DENJYGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Mirejai commented 1 week ago

That's not what I meant. Actually the organ must be loaded to change settings. Then we must reload the organ to apply the changes. It’s pretty obvious that changing the settings every time we load the organ is completely useless. I meant that offering an option to changes organ settings without loading it (by adding an additional option in the file menu to change the settings and immediately load the organ after, or by adding an option to modify settings in the organ list) would be great.

oleg68 commented 1 week ago

But this is only a problem of the first load of an organ. After the first load, changing it's settings and saving them, you are non more necessary to repeat it at future loads of the same organ.

From the other side, accessingthe organ settings dialog with exposing the organ structure requires that the organ would be loaded even partially, otherwise GO does not know about objects the organ contain.

There is already a "just gui" option of loading an organ. Of cause we can add an additional option "bring organ settings before full loading", but the user cannot know if some changes should be applied before the first (unsucsessful) attempt of loading. So I consider the worth of this enhancement as very low and there are very few use cases when it would be useful.