GrandOrgue / grandorgue

GrandOrgue software
Other
148 stars 39 forks source link

Extracted class GODeviceNamePattern from GOMidiDeviceConfig #1929

Open oleg68 opened 6 days ago

oleg68 commented 6 days ago

This is the first PR related to #1265

It extracts the matching device name code from GOMidiDeviceConfig to a new class GODeviceNamePattern.

It is just refactoring. No GO behavior should be changed.

larspalo commented 2 days ago

@oleg68 While testing this PR I noticed that I get consistent crashes when enabling the Lossless compression (without compression it seems to be ok). My settings usually was Linear interpolation, 24 bit 48 kHz with the lossless compression when the crash happens. Doesn't matter what sample set I use. It's loaded and soon after playing a few notes on it, GO will crash.