GrandOrgue / grandorgue

GrandOrgue software
Other
159 stars 40 forks source link

GO freezing issues #1956

Open obw-go opened 1 month ago

obw-go commented 1 month ago

When out of the blue the Panic button is pushed or the Panic option is choosen from the menu, GO freezes.

When I changed the language to Dutch, quit GO and start GO again and try to change language to English, Go freezes.

rousseldenis commented 1 month ago

Hi @obw-go, could you provide more information?

On which environnement you are (win, linux, Mac), which version of GO you are using.

Thanks

obw-go commented 1 month ago

@rousseldenis I get this freezing with the present build I use for my work on the Dutch translations of the nl.po files. Environment: Ubuntu 20.4.6 under VirtualBox under Windows 10 on a 64bits PC. After building and installing the package grandorgue_3.14.3-0_localamd64.deb and running GO this freezing occurs with the two examples given.

larspalo commented 1 month ago

After building and installing the package grandorgue_3.14.3-0_localamd64.deb and running GO this freezing occurs with the two examples given.

Just FYI, for local development there's more or less no point in creating the package and/or installing GO (that's done to facilitate easy distribution). You can equally well just run the compiled binary from the /bin directory and skip all the extra steps.

obw-go commented 1 month ago

@larspalo Thx for the hint - this saves me time!

oleg68 commented 1 month ago

This issue looks like one was fixed with https://github.com/GrandOrgue/grandorgue/commit/faa554bc7202cd323970243fe8f1ee0ea4b05b7a.

@obw-go Could you try to disable sample set caching and to delete the existing cache files. Will GO still hang?

If no then the right way to fix it is to update your source tree with the latest one from github and to rebuild GrandOrgue.

obw-go commented 1 month ago

@larspalo

Just FYI, for local development there's more or less no point in creating the package and/or installing GO (that's done to facilitate easy distribution). You can equally well just run the compiled binary from the /bin directory and skip all the extra steps.

I looked into the bin directory, but did not find a program icon to start GO...: bin_no_program_icon

Ah - I see in the first screencast of GOODF howto start GO in the terminal with ./GOODF..., so it seems that also a file without extension can by started the same way as a .sh file.... works also for GrandOrgue...

obw-go commented 1 month ago

@oleg68

Could you try to disable sample set caching and to delete the existing cache files. Will GO still hang?

I removed the Cache (using the menu-option), and after that went to the Settings menu-option and disabled the option Automatic Cache Management (or something like this - I see the Dutch text now)... After clicking OK the program freezes again.

Do you know which git commando I have to use in order to refresh the source stuff on my local computer?

oleg68 commented 1 month ago

@oleg68

Could you try to disable sample set caching and to delete the existing cache files. Will GO still hang?

I removed the Cache (using the menu-option), and after that went to the Settings menu-option and disabled the option Automatic Cache Management (or something like this - I see the Dutch text now)... After clicking OK the program freezes again.

You have to start GrandOrgue again for using these new settings. Please check that the cache file does not exist. Does GO hang?

Do you know which git commando I have to use in order to refresh the source stuff on my local computer?

git pull

or

git fetch ; git merge origin/master

obw-go commented 1 month ago

You have to start GrandOrgue again for using these new settings. Please check that the cache file does not exist. Does GO hang?

I first removed the files from the Cache directory by hand before starting GO. In the Cache directory I can see again two files related to the demo organ popping up. When I do the checks (pushing Panic button, change language option in the Settings), the program no longer freezes.... So it seems that the freezing is related to something in the cache file(s)...

obw-go commented 1 month ago

git fetch ; git merge origin/master

After this command I got the screenmessage: nothing_refreshed

So it seems nothing in the source needed to be refreshed?

oleg68 commented 1 month ago

So it seems that the freezing is related to something in the cache file(s)...

Update your GO codebase to peak the fix https://github.com/GrandOrgue/grandorgue/commit/faa554bc7202cd323970243fe8f1ee0ea4b05b7a and rebuild GrandOrgue. Then enable the cache again. Does GO freese?

obw-go commented 1 month ago

Update your GO codebase to peak the fix faa554b

Sorry Oleg - this "codebase to peak the fix" is Chinese for me!

oleg68 commented 1 month ago

@obw-go what is your current git branch?

git branch

obw-go commented 1 month ago

@oleg68

@obw-go what is your current git branch?

git branch

git_branch

And installation did take considerable time and space... And still "git branch" not working. So I want to remove again what was installed and takes useless space now... Do you know how I can do that?

Ah, with some googeling I find the command purge that can be used and this seemed to do the job... And it was my own fault: misspelling branche for branch.... pffffft

obw-go commented 1 month ago

@oleg68

what is your current git branch?

oleg68 commented 1 month ago

@obw-go Then git pull should help you.

obw-go commented 1 month ago

@oleg68 Thx! This worked - I saw some updating of some files done...

oleg68 commented 1 month ago

Does the freesing still occur with the new code and the cache enabled?

obw-go commented 1 month ago

@oleg68

Hi Oleg, Also after git pull and making a new build, having active the next cache settings: cache-settings

GO freezes again, when I change the Language from Dutch to Default English and click on OK.

obw-go commented 1 month ago

@oleg68 Also after updating my local system with the last Release files, the freezing persists when I change an option in the Settings and click on OK. After that I have to choose for "Force Quit" every time...