GrandTheftWalrus / RuneLite-World-Heatmap

A plugin that lets you visualize the tiles of the Old School Runescape world map that you most often visit
BSD 2-Clause "Simplified" License
5 stars 3 forks source link

[Request] Better filename #9

Closed JasperSurmont closed 2 months ago

JasperSurmont commented 2 months ago

Wouldn't it make more sense to, instead of the userId, write the files with the date (+time) as filename? Perhaps in a directory with the userId?

Also, the files written start with a minus (-) for me, which command line applications cannot handle too well (so I had to rename it first).

GrandTheftWalrus commented 2 months ago

This functionality might have been broken at some point but the plugin is supposed to keep backups which are named after user ID and datetime in a backups folder. User ID is used in the filenames because people can log into different accounts on the same machine and I wanted to keep em separated (also I didn't use OSRS usernames because they can change over time for an account). For some reason, OSRS user IDs all seem to be negative numbers, and I kept them as-is because minuses are legal filename characters and can just be surrounded with quotations if needed

JasperSurmont commented 2 months ago

Okay, that makes sense. For me all pictures are just stored in the folders without any date / time in the name, which I assume is also causing it to overwrite previous images. This makes the autosave feature not really work since you need to edit the filename each time.

I can take a look if you want why the date is being omitted?

I think the best structure would be:

worldheatmap
 | Heatmap Files
   | UserID
     | YYMMDD
       - Files
 | Heatmap Images
   | UserID
     | YYMMDD
       - Files

Any thoughts?

GrandTheftWalrus commented 2 months ago

Okay, that makes sense. For me all pictures are just stored in the folders without any date / time in the name, which I assume is also causing it to overwrite previous images. This makes the autosave feature not really work since you need to edit the filename each time.

I can take a look if you want why the date is being omitted?

The autosave feature is only for the .heatmaps files, not for images, and they should be being stashed in this folder: image I don't have any recent files inside my backup folder though, which leads me to believe that I might have broken the autosave feature at some point in time. I'll shrek that out when I get some time (or you can see why it's busted if you're pinterested). There should be files in it that are named something like [userId]_yyyy-mm-dd-hh-ss.heatmaps.

I think the best structure would be:

worldheatmap
 | Heatmap Files
   | UserID
     | YYMMDD
       - Files
 | Heatmap Images
   | UserID
     | YYMMDD
       - Files

Any thoughts?

Yee I suppose that would be better for organization/finding files, each account having its own folders for heatmap files/images

JasperSurmont commented 2 months ago

I'll look at it tonight and see how far I get.

JasperSurmont commented 2 months ago

Closed with #10