search

Grandi0z / Space_travelers_hub

Space Travelers is a web application that allows users to learn about and participate in space exploration. The application retrieves missions and rockets from SpaceX and allows users to join missions and reserve rockets. Users can also create their own profiles and track their progress as they work towards becoming space travelers.
MIT License
0 stars 0 forks source link

Project description #25

Open Grandi0z opened 1 year ago

Grandi0z commented 1 year ago

Project link: https://github.com/Grandi0z/Space_travelers_hub/projects/2 Team members: 2

mukhammadrizooff commented 1 year ago

Hi @TEAM,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Required Changes ♻️

image

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Felix45 commented 1 year ago

Approved :green_circle:

Hi @Grandi0z & @akbarsazish ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights :heavy_check_mark:

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

prolajumokeoni commented 1 year ago

Hi @Grandi0z and @akbarsazish

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that does not follow the proper way to get a review, please merge all your pull requests to the dev branch and open a pr from the dev branch into main, please see the guidelines on how to request a review 👍🏿

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.