search

Grandt / PHPePub

PHP Classes for dynamically generating EPub files.
http://www.phpclasses.org/package/6115
241 stars 83 forks source link

php72, download utf8 filename #50

Open mytory opened 6 years ago

mytory commented 6 years ago

1

php 7.2 deprecated each function. And Laravel framework doesn't permit deprecated function. I've intended to use this project in my Laravel project, but the framework throw ErrorException.

ErrorException

So, I changed all each() function to foreach() control structure.

2

$book->sendBook($download_filename); this code does not pass $utf8filename parameter to sendZip function. So I added an argument(2287 line in PHPePub\Core\Epub).

Thanks.

Daniel-KM commented 5 years ago

@Grandt There are some fixes/improvements in other forks too. Do you think you will merge them too? Thanks.

iooe commented 5 years ago

@Daniel-KM last activity of @Grandt was in 2016 year. @mytory you can register your fork in packagist ?