Grandt / PHPePub

PHP Classes for dynamically generating EPub files.
http://www.phpclasses.org/package/6115
241 stars 83 forks source link

header footer in separate functions #7

Open riconeitzel opened 12 years ago

Grandt commented 12 years ago

The header and footer in separate functions are quite ok. We just have to make sure that the splitter aren't going to get into trouble, it doesn't expect the header to be present at that point. If I recall. And it does add its own header structure.

The other pull looks like an old version, I probably shouldn't merge that into my code :)

On 03-09-2012 22:03, Rico Neitzel wrote:


    You can merge this Pull Request by running:

git pull https://github.com/riconeitzel/PHPePub master

Or view, comment on, or merge it at:

https://github.com/Grandt/PHPePub/pull/7

    Commit Summary

— Reply to this email directly or view it on GitHub https://github.com/Grandt/PHPePub/pull/7.