search

GrandyB / SheetsIO

Small configurable Java app that pulls data from a Google Spreadsheet (using v4 api) and writes to files and a local webserver.
GNU Lesser General Public License v3.0
22 stars 3 forks source link

Japanese Hiragana text doesn't copy over to the .txt files correctly #48

Closed TheMooSpl closed 1 year ago

TheMooSpl commented 1 year ago

Is your feature request related to a problem? Please describe. Currently, SheetIO isn't pulling Japanese hiragana characters into .txt files, for example: What's on the google sheet: αWings☆つばさ What's in the .txt file: αWings☆�?��?��?�#2961 What's in OBS: αWings☆�?��?��?�#2961

When I copy "αWings☆つばさ" into the .txt manually, it displays correctly in OBS.

Describe the solution you'd like SheetIO to pull in hiragana using UTF-8

Describe alternatives you've considered The alternative is putting each name with hiragana in manually, but it is common to have both English and Japanese in a name with what I do. Each team has a max of 8 players, that's around max 16 players displayed onscreen so grabbing all that info and inputting it manually is very difficult.

Additional context These are some of the names that won't display. One I due to emotes, which I'm not too concerned about but the others are all hiragana. You can see that the katakana shows up but not the hiragana. image

GrandyB commented 1 year ago

Thank you for the detailed examples; will replicate locally and see what can be done.

GrandyB commented 1 year ago

Replicated and fixed. Both the response reader (from the API call to Google) and the file writer (to text file) were both not using UTF-8. They now do.

Tried "αWings☆つばさ" and "%22~👀🤍", both of which get into the text files now, so hopefully both the Japanese characters and emojis should work.

Will push it up shortly and put into a hotfix as soon as I can (hopefully in the next hour... the jar packaging process is being a pain).

GrandyB commented 1 year ago

@TheMooSpl can you please try out the hotfix on the latest pre-release. This build has some other new changes in I'd appreciate any testing for too.

https://github.com/GrandyB/SheetsIO/releases/tag/v0.7.3.1

TheMooSpl commented 1 year ago

Everything seems to be in working order, the characters show up completely fine and I think the blank file failsafes are also working too. Thank you so much for this and being so quick!

GrandyB commented 1 year ago

Jolly good; thanks for reporting it to me - would never have known otherwise.

Closing as fixed in 0.7.3.1