search

GrangerHub / tremulous

Other
81 stars 18 forks source link

Broke GPP connection #118

Closed Buom01 closed 3 years ago

Buom01 commented 3 years ago

Hi,

I noticed that I have broke compatibility with GPP server with the following line: https://github.com/Buom01/tremulous/blame/647bc2bae35e6ac1ccd74479b123bc60ade5a446/src/game/bg_public.h#L86 in the merged pull request: https://github.com/GrangerHub/tremulous/pull/104

Connecting to 1.1.0 servers isn't affected at all.

Symptoms: Wrong songs, and other weird stuff on GPP servers.

A word about the broke: It were introduced by implanting a graphical team status with a bad design: I should have used cvar instead of touching CS_*. Even if I did all my code with compatibility in mind I only noticed it while trying to open a GPP server. That's also because I shouldn't mix so different things in a single pull request... which made it harder to review also because GitHub's filters are almost useless too.

I will patch it when I have free time, and when I found a workaround for gcc-10 (I will open issues for it too). It would be changed to allow the server to get some enhancement, and will be like not existent if the server is not patched (at server side only): "Progressive".

Buom01 commented 3 years ago

Close as it would be fixed on https://github.com/GrangerHub/tremulous/pull/121 No real solution found except reverting it (as it would need custom QVM else)