Granitosaurus / xonsh-autoxsh

Automatically execute scripts for directories in Xonsh Shell.
GNU General Public License v3.0
15 stars 7 forks source link

Breaks cd command behavior in shell #1

Closed fisadev closed 6 years ago

fisadev commented 8 years ago

Activating this xontrib breaks the behavior of cd without arguments, as explained in this xonsh issue: https://github.com/xonsh/xonsh/issues/1484 In the comments, near the end, the culprit line in autoxsh is specified (related to an import).

PaulReiber commented 8 years ago

If I'm right this should be a super easy fix.

instead of: from xonsh.dirstack import cd

we would rename cd on the way in: from xonsh.dirstack import cd as _cd

then 7 lines below that: rtn = _cd(args, stdin=stdin)

Kind regards,

_Paul Reiber_http://about.me/reiber

On Mon, Jul 25, 2016 at 10:18 PM, Juan Pedro Fisanotti < notifications@github.com> wrote:

Activating this xontrib breaks the behavior of cd without arguments, as explained in this xonsh issue: xonsh/xonsh#1484 https://github.com/xonsh/xonsh/issues/1484 In the comments, near the end, the culprit line in autoxsh is specified (related to an import).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Granitas/xonsh-autoxsh/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AADlQNMZaFmQqdiyfz6AVqTfIeVXRzcvks5qZZicgaJpZM4JUyvy .

fisadev commented 8 years ago

PR done, thanks @PaulReiber for the info on how to fix it. Hope they merge it :)

Granitosaurus commented 6 years ago

Fixed