search

Granola-Team / mina-block-explorer

Web application for the Mina blockchain
Apache License 2.0
6 stars 6 forks source link

Problem: "Block Height" metric has unclear semantics #807

Closed robinbb closed 2 months ago

robinbb commented 2 months ago

"Block Height"? The user might think that blocks each have a height, and the current height is 9999, say. It is the chain of blocks that has this height (or length). I think that it must be "Blockchain Height" or "Blockchain Length". The protocol itself uses the term "blockchain length" in its blocks, note. So, that term is the least ambiguous, IMO.

robinbb commented 2 months ago

ME has "Blockchain Length" as its metric.

Isaac-DeFrain commented 2 months ago

To muddy the waters, the "height" of a node in a tree is the "length" of the chain of nodes from root to the desired node (inclusive) - 1. These two terms are consistently used as synonyms.

robinbb commented 2 months ago

Ah, so it is the case that each block has a "height" property, after all. I feel that this strengthens the argument for a rename of this metric to simply "Blockchain Length".