search

Granola-Team / mina-block-explorer

Web application for the Mina blockchain
Apache License 2.0
7 stars 6 forks source link

chore: add .envrc to gitignore #841

Closed jhult closed 3 months ago

robinbb commented 3 months ago

But the .envrc is not to be ignored? We check it in. We change it as needed. Maybe you're thinking of the .env file?

jhult commented 3 months ago

But the .envrc is not to be ignored? We check it in. We change it as needed. Maybe you're thinking of the .env file?

@robinbb,

https://www.toptal.com/developers/gitignore/api/direnv recommends to ignore .envrc. More details here and here.

robinbb commented 3 months ago

That first document has a link to https://github.com/direnv/direnv/wiki/.envrc-Boilerplate which says ".gitignore .env, but commit .env{rc,.sample,*} files; see Git Tips". It does not say to ignore .envrc. Also, even if it did, I would argue with it. The .envrc is intended to convey how to configure the developer environment so that all devs are working from same environment.

jhult commented 3 months ago

Since I don't have strong feelings on this, and since the https://github.com/direnv/direnv wiki has conflicting info, I'm going to close this.