search

Granola-Team / mina-block-explorer

Web application for the Mina blockchain
Apache License 2.0
6 stars 5 forks source link

feat: beta ribbon #914

Closed jhult closed 1 week ago

jhult commented 1 week ago

Resolves Granola-Team/mina-block-explorer#913

image
n1tranquilla commented 1 week ago

Very sharp

n1tranquilla commented 1 week ago

@jhult can you post a shot of the mobile view? It seems mobile tests are failing.

jhult commented 1 week ago

It hides the hamburger button. You can still click on it though.

image image
robinbb commented 1 week ago

Shouldn't the hamburger button be in the upper right, anyway? @jhult

robinbb commented 1 week ago

@n1tranquilla What do you think of moving the hamburger to upper right? Would be consistent with the non-mobile website view.

n1tranquilla commented 1 week ago

@robinbb I won't refuse any PR that moves the menu to the right!

jhult commented 1 week ago

Fixed mobile by adding class max-md:hidden.

n1tranquilla commented 1 week ago

@jhult if you are looking to hide on mobile, the fragment would be "... hidden md:block ...". See tailwind's mobile-first approach. This is not a required change.

CI is failing right now due to prod deployment.

n1tranquilla commented 1 week ago

This is ready to merge, but we should hold off until we have all the blocks

robinbb commented 1 week ago

I think we should just merge. We're close enough!