Feetransfers does not support filtering to exclude coinbase rewards

[n1tranquilla]

We're interested in querying those two separately or together.

[trevorbernard]

@n1tranquilla If you look at it from the context of an internal command, then it makes sense include both but if we use the terminology of "Fee Transfer" then a coinbase is not a fee transfer but a reward. The reason why we've separated it so far is because that's what ME does and that's how the API looks with the Mina node.

[robinbb]

Do we need to exclude coinbase rewards? Do we want fee transfers, or internal commands?

[n1tranquilla]

To display fees here, I have to filter out coinbase rewards in the javascript. Here is a case where I want to display fees, not coinbase rewards.

[robinbb]

Not sure if this should be back-end. Is it already done in the front-end?

[n1tranquilla]

I think it should be a GQL query option, but i'm content for now, to filter using magic number (ie < 720 MINA)

[robinbb]

That filter will cause the most interesting of fees to be excluded.

[n1tranquilla]

That's why we need the filter for https://minasearch.com/analytics/commands/internal. We want to get all fees, except coinbase rewards. This filtering (done client-side) is just a guess as there are likely no fees that ever approach block reward levels. But if there are, i'm filtering them out (hence the need for server-side filter).

@trevorbernard can I transfer this to mina-indexer?

[trevorbernard]

To display fees here, I have to filter out coinbase rewards in the javascript. Here is a case where I want to display fees, not coinbase rewards.

But why are we filtering them out? The link says internal_commands for which the Coinbase reward is one.

[trevorbernard]

This is something we can support:

query MyQuery {
  feetransfers(query: {type_nin: ["Coinbase"]}) {
    blockHeight
    canonical
    dateTime
    fee
    recipient
    type
  }
}

[trevorbernard]

Alternatively we just don't return coinbase rewards in that endpoint and add internal_commands endpoint