search

Granola-Team / mina-indexer

The Mina Indexer is a re-imagined version of the software collectively called the "Mina archive node."
Apache License 2.0
18 stars 10 forks source link

Merges are allowed before CI pipeline has completed successfully #854

Closed jhult closed 3 months ago

jhult commented 4 months ago

Example:

image
robinbb commented 4 months ago

@jhult I think that this is corrected, now, via changes to settings in both Buildkite and GitHub (no code changes to reflect this, alas). Please verify.

jhult commented 4 months ago

This still seems to be a problem

Screenshot_20240518-151528

robinbb commented 4 months ago

@jhult New status on this: I believe that it is possible to add the PR to a merge queue before the CI for the PR (by itself) completes. That makes sense, but also the user should be able to configure this on/off. Based on the GitHub settings for this repo, it should be that promoting the PR to the merge queue before it has passed CI is disallowed. However, it seems that some settings are simply disregarded if there is a merge queue. Worse, the PR is marked "merged" before either CI run (the PR's run, or the merge queue's run) have succeeded. Yet worse still, GitHub closes/deletes the branch used to run the merge queue after it completes, leaving no evidence of what happened. Did it pass the merge queue? Or, did it fail, and the PR regardless closed?

robinbb commented 3 months ago

I have reverted the "merge queue" functionality. It still may be that merges are allowed before the CI checks have passed. Let me know, @jhult .