search

Granola-Team / mina-indexer

The Mina Indexer is a re-imagined version of the software collectively called the "Mina archive node."
Apache License 2.0
18 stars 10 forks source link

Problem: the genesis ledger is not part of the binary #921

Closed robinbb closed 3 months ago

robinbb commented 3 months ago

The idea is to render unnecessary the "--genesis-ledger " command line switch by including the file verbatim in the mina-indexer binary. This means that we won't need to parse a file, but a static string.

This is important because it is very error-prone to ensure that the file is installed into the right place on the user's machine.

This makes the Nix-built image more difficult to get right, and indeed it is not working at present because of this.

Old requirement: Just use https://doc.rust-lang.org/std/macro.include_str.html to pull it into the binary at compile time. This avoids the awkward need to deploy that file somewhere on the user's machine.

robinbb commented 3 months ago

Isaac's PR (#1056) may have included the ledger, but the "--genesis-ledger" command line switch still exists and is required, so is not what I had in mind with this issue. I will re-open, and better specify what is desired.

robinbb commented 3 months ago

Command line switch is no longer required. Closing.