Grant-Nelson / ThreeDart

3D graphical rendering tool for websites written in Dart.

Other

16 stars 11 forks source link

Bug fixes001 #131

Closed Grant-Nelson closed 4 years ago

Grant-Nelson commented 4 years ago

Issue #130 and #129

Bugs/Problems

Figure out and fix the scroll wheel zoom speed on Mozilla
The spotlight doesn't work on Chrome on Macs. Figure out what is wrong and fix it without breaking it on Windows. Should also check on Chrome and Mozilla.

Implementation

Bump the copyright year
Bump the version number
Added Environment which lets us determine the browser and OS
Fixed the problem with the scroll wheel zoom on Firefox by changing the scroll wheel scalar if the browser type is Firefox
Fixed the spotlight on Macs by having the glsl shader for spotlight not use acos which appears to have issues but instead use an atan equivalent
Fixed some spelling
Fixed a test 48 description

Review and Testing

[x] Check Firefox and Chrome on Windows and Mac
[x] Check spotlight and textured spotlight
[x] Check scroll wheel on speed on several tests
[x] Check the unit-tests

Grant-Nelson commented 4 years ago

Since no one else is here to perform the review, I did it myself and checked that it worked +10