search

GrantGryczan / Miroware

File Garden
https://filegarden.com
MIT License
18 stars 3 forks source link

>100 MiB uploads #11

Open GrantGryczan opened 4 years ago

GrantGryczan commented 4 years ago

Let users upload individual files which are greater than 100 MiB in size. This should be a paid feature.

Friuuu commented 6 months ago

This feature can be easily added by copying code from example https://github.com/BobbyWibowo/lolisafe there. It says in the featurelist: Chunked uploads to support 100MB+ files when hosted behind Cloudflare, or any other proxies with file upload size limits. And it should be a free feature.

GrantGryczan commented 6 months ago

@Friuuu You can't simply copy code from another app and expect it to work as-is, so it doesn't exactly help to reference another project that has implemented this feature in a different way, for a different storage provider, and with a different database architecture. I already know how to implement this feature, so seeing an example of it written in another codebase is not the problem.

I'm currently in the process of rewriting File Garden anyway, to vastly improve maintainability and performance. I will add significant new features like this during the rewrite, which will be much easier than amending this old codebase.

As for whether it should be a free feature--storage is very expensive. I'd worry that letting people upload these large files for free would likely limit File Garden's longevity. I have seen time and time again that with the 100 MiB restriction we have now, people usually just find a way to make their files smaller (it's usually some HTML5 animation with too many unused resources included in the export, or an unnecessarily uncompressed video, for example). (That or it's something people shouldn't be uploading in the first place, like a pirated EXE file.) It's good to make reducing enormous file sizes a natural route for users so that FG's storage is not consumed by enormous files unnecessarily.

And even if I do make it a paid feature, FG is open-source, so you'll always be able to simply clone it for yourself and self-host it without any such restrictions. :)

The discussion of whether it should be free doesn't concern the codebase and so doesn't belong here though, so I encourage you to bring any additional concerns you have to File Garden's Discord server if you'd like to continue that discussion! I actually am looking for feedback on FG's future pricing model there right now.