search

GrantGryczan / Miroware

File Garden
https://filegarden.com
MIT License
18 stars 3 forks source link

Update POST.njs for consistency #label enhancement #41

Closed dress4 closed 1 year ago

dress4 commented 1 year ago

I

t already says that a paid subscription is required to change privacy settings to private. this #11 will be added eventually I assume so this makes sense

GrantGryczan commented 1 year ago

Not sure this is necessary considering there's already a client-side check with a better error message. The error message you're editing is the API error, not the error that users see.

Also, this is unrelated but, I understand wanting to have a little fun and be informal, but in a setting like GitHub, that makes things a bit more confusing (and time-consuming) for me to look at. In the future, I recommend staying on the side of conventional (e.g. naming the fork the same as what you're forking, not using weird formatting in your PR description, not reviewing your own code for no reason, not posting a rickroll, and not reacting to your own review with every reaction). Keep it minimal and formal. Following conventions allows the whole process to go according to my expectations so it's quick and easy for me to look through.

Also worth noting I couldn't even merge this PR if I wanted to, since you marked it as a draft. I'm going to close it anyway though, unless you have any further objections.