search

GrantMStevens / amCharts-Angular

Angular directive for amCharts library
Apache License 2.0
63 stars 39 forks source link

Make the margins configurable. #14

Closed rguico closed 9 years ago

rguico commented 9 years ago

The margins (auto and fixed) need to be configurable; the current default setting cuts off the top axis for me, and it looks really bad when I enable chartScrollbar.

GrantMStevens commented 9 years ago

This is redundant. I set the defaults before iterating over o.Keys. If any margin properties exist on o, they will overwrite the defaults.

Edit: creditsPosition is the one that should be modified, as it is redundant in the same way your code is. If someone changes the value of creditsPosition, it will get set twice. Not really a big deal, as its a trivial operation to set the value of an int or string twice to the same thing, but its not as clean.

rguico commented 9 years ago

Got it, I see where you did that, and the way I tested I didn't get around to trying that first.

Thanks! Robert