GrantThorntonETSI / eFile_Reimagined

Efile Reimagined
1 stars 0 forks source link

Error message "the field is required" #161

Open JackieBabos opened 5 years ago

JackieBabos commented 5 years ago

The error should read “This field is required.” https://uspto.github.io/designpatterns/1.x/docs/components/forms.html#form-validation

image

dutchTender commented 5 years ago

image @l-stanny see my screen shot of the latest build. we are now using html5 "required" attribute on form required fields, so the original screen of the issues showing server responded validation is no longer the case ... do you know how we can customize this html5 validation message?? i did some google search, and they are talking about some type of validity attribute which i didn't quite understand ...

keytie commented 5 years ago

If this is the standard HTML5 validation message for 'required' fields and requires writing a custom validation message, i would say leave it as is.

l-stanny commented 5 years ago

Here is a good article on using the HTML5 pattern attribute to customize how required functions and also customize the required CSS: https://www.sitepoint.com/html5-form-validation/

This article https://www.washington.edu/accessibility/checklist/form-validation/ discusses, in more detail, accessibility

Lynn Using Accessible Methods of Form Validation | Accessible Technology - washington.eduhttps://www.washington.edu/accessibility/checklist/form-validation/ www.washington.edu Overview. Even if forms are coded properly for accessibility, users may make mistakes.They may inadvertently skip required fields, or enter invalid information. A well-designed online form provides helpful and timely feedback to users so they can easily correct errors and resubmit the form.

[https://www.sitepoint.com/wp-content/themes/sitepoint/assets/images/icon.html-css.png]https://www.sitepoint.com/html5-form-validation/

HTML5 Form Validation — SitePointhttps://www.sitepoint.com/html5-form-validation/ www.sitepoint.com A walkthrough in validating a simple booking form by using the Constraint API, and keep an eye on how you can make sure your forms stay accessible too.


From: li zhang notifications@github.com Sent: Wednesday, December 19, 2018 8:42 PM To: GrantThorntonETSI/eFile_Reimagined Cc: Stanikmas, Lynn; Mention Subject: Re: [GrantThorntonETSI/eFile_Reimagined] Error message "the field is required" (#161)

[image]https://user-images.githubusercontent.com/7011252/50258502-f8de2d80-03cd-11e9-9cd0-44e6440f96ed.png @l-stannyhttps://github.com/l-stanny see my screen shot of the latest build. we are now using html5 "required" attribute on form required fields, so the original screen of the issues showing server responded validation is no longer the case ... do you know how we can customize this html5 validation message?? i did some google search, and they are talking about some type of validity attribute which i didn't quite understand ...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/GrantThorntonETSI/eFile_Reimagined/issues/161#issuecomment-448827486, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH5HjL8tOodJFY1GBEqAvTG6Lw4IM57hks5u6urmgaJpZM4ZbIPZ.

[GT Image]

http://www.grantthornton.com/Grant Thornton LLP is the U.S. member firm of Grant Thornton International Ltd. Grant Thornton International Ltd and its member firms are not a worldwide partnership, as each member firm is a separate and distinct legal entity. In the U.S., visit Grant Thornton LLP at GT.com. http://www.grantthornton.com Please understand that, unless expressly stated otherwise, any written advice given by Grant Thornton LLP that is contained in, forwarded with, or attached to this e-mail is: (1) limited to the matters and potential tax consequences specifically addressed herein, and; (2) not intended or written by Grant Thornton LLP as advice on the application or potential application of any penalties that may be imposed under any federal, state, or foreign statute or regulation in any manner. This e-mail is intended solely for the person or entity to which it is addressed and may contain confidential and/or privileged information. Any review, dissemination, copying, printing or other use of this e-mail by persons or entities other than the addressee is prohibited. If you have received this e-mail in error, please contact the sender immediately and delete the material from any computer.

Please consider the environment before printing this email.

dutchTender commented 5 years ago

thanks. i will read this see how we can customize it.

On Thu, Dec 20, 2018 at 11:44 AM Lynn Stanikmas notifications@github.com wrote:

Here is a good article on using the HTML5 pattern attribute to customize how required functions and also customize the required CSS: https://www.sitepoint.com/html5-form-validation/

This article https://www.washington.edu/accessibility/checklist/form-validation/ discusses, in more detail, accessibility

Lynn Using Accessible Methods of Form Validation | Accessible Technology - washington.edu< https://www.washington.edu/accessibility/checklist/form-validation/> www.washington.edu Overview. Even if forms are coded properly for accessibility, users may make mistakes.They may inadvertently skip required fields, or enter invalid information. A well-designed online form provides helpful and timely feedback to users so they can easily correct errors and resubmit the form.

[ https://www.sitepoint.com/wp-content/themes/sitepoint/assets/images/icon.html-css.png ]https://www.sitepoint.com/html5-form-validation/

HTML5 Form Validation — SitePoint< https://www.sitepoint.com/html5-form-validation/> www.sitepoint.com A walkthrough in validating a simple booking form by using the Constraint API, and keep an eye on how you can make sure your forms stay accessible too.


From: li zhang notifications@github.com Sent: Wednesday, December 19, 2018 8:42 PM To: GrantThorntonETSI/eFile_Reimagined Cc: Stanikmas, Lynn; Mention Subject: Re: [GrantThorntonETSI/eFile_Reimagined] Error message "the field is required" (#161)

[image]< https://user-images.githubusercontent.com/7011252/50258502-f8de2d80-03cd-11e9-9cd0-44e6440f96ed.png

@l-stannyhttps://github.com/l-stanny see my screen shot of the latest build. we are now using html5 "required" attribute on form required fields, so the original screen of the issues showing server responded validation is no longer the case ... do you know how we can customize this html5 validation message?? i did some google search, and they are talking about some type of validity attribute which i didn't quite understand ...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub< https://github.com/GrantThorntonETSI/eFile_Reimagined/issues/161#issuecomment-448827486>, or mute the thread< https://github.com/notifications/unsubscribe-auth/AH5HjL8tOodJFY1GBEqAvTG6Lw4IM57hks5u6urmgaJpZM4ZbIPZ

.

[GT Image]

http://www.grantthornton.com/Grant Thornton LLP is the U.S. member firm of Grant Thornton International Ltd. Grant Thornton International Ltd and its member firms are not a worldwide partnership, as each member firm is a separate and distinct legal entity. In the U.S., visit Grant Thornton LLP at GT.com. http://www.grantthornton.com Please understand that, unless expressly stated otherwise, any written advice given by Grant Thornton LLP that is contained in, forwarded with, or attached to this e-mail is: (1) limited to the matters and potential tax consequences specifically addressed herein, and; (2) not intended or written by Grant Thornton LLP as advice on the application or potential application of any penalties that may be imposed under any federal, state, or foreign statute or regulation in any manner. This e-mail is intended solely for the person or entity to which it is addressed and may contain confidential and/or privileged information. Any review, dissemination, copying, printing or other use of this e-mail by persons or entities other than the addressee is prohibited. If you have received this e-mail in error, please contact the sender immediately and delete the material from any computer.

Please consider the environment before printing this email.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/GrantThorntonETSI/eFile_Reimagined/issues/161#issuecomment-449061178, or mute the thread https://github.com/notifications/unsubscribe-auth/AGr7tDDZFkCL2FX62LrLITTSpu3anMKcks5u675fgaJpZM4ZbIPZ .

dutchTender commented 5 years ago

@keytie just saw your note. i will leave this then and put it in the back log bucket