GrantThorntonETSI / eFile_Reimagined

Efile Reimagined
1 stars 0 forks source link

Missing "*" for required data fields on Owner Edit Page #424

Open nguyenvivi opened 5 years ago

nguyenvivi commented 5 years ago

image

dutchTender commented 5 years ago

ok

dutchTender commented 5 years ago

@nguyenvivi would we be required to block user from try to save empty text?

nguyenvivi commented 5 years ago

@dutchTender - User should not be able to save the form if they miss the required data field. It should carry the same validation checks as the original form. Hope this makes sense.

nguyenvivi commented 5 years ago

In this Scenario, we have the attorney representative. In the original owner page, the email address is not required field, which is correct. However, in the owner edit page, the email address field is required. Please remove the "*" from the email field on the owner edit page IF and ONLY IF there is an attorney representative.

image

dutchTender commented 5 years ago

this is probabbly the biggest rewrite to date. i am going to list the things that need to change, as contact email is a fundational peiece to the design of the data model.

  1. managed contacts ( can not use emails to look up) -
  2. attorney and owners (which inherits from managed contacts ...need to not use emails for look up)
  3. general partners (needs updated.) those are linked to owners by owner emails
  4. owner and attorney edit pages and also owner and attorney uploads all needs to be rewritten
dutchTender commented 5 years ago

i have no time line for this. as the most difficult part to this would be making sure we are not introducing bugs as how pervasive emails are being used in the application

dutchTender commented 5 years ago

also logic for detecting if an attorney or owner should be created in managed contacts as well, also the managed contacts auto fill functionality needs to be updated as well.

dutchTender commented 5 years ago

we will open a separate issue for making owner email not a required field.