Grantapher / ValheimPlus

A HarmonyX Mod aimed at improving the gameplay and quality of life of the game Valheim.
GNU Affero General Public License v3.0
220 stars 24 forks source link

[BUG] Trying to Craft Raw Fish recipe crashes game #40

Open Grantapher opened 10 months ago

Grantapher commented 10 months ago

When crafting image

the game crashes with

[Error  : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
Recipe.GetAmount (System.Int32 quality, System.Int32& need, ItemDrop+ItemData& singleReqItem) (at <451885e1da994a249df7e844d70107b7>:0)
InventoryGui.OnCraftPressed () (at <451885e1da994a249df7e844d70107b7>:0)
UnityEngine.Events.InvokableCall.Invoke () (at <50b18efe22344b9eb3b7d77b08ea287f>:0)
UnityEngine.Events.UnityEvent.Invoke () (at <50b18efe22344b9eb3b7d77b08ea287f>:0)
UnityEngine.UI.Button.Press () (at <042da27c9af642978a8a5138113c4eed>:0)
UnityEngine.UI.Button.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at <042da27c9af642978a8a5138113c4eed>:0)
UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at <042da27c9af642978a8a5138113c4eed>:0)
UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at <042da27c9af642978a8a5138113c4eed>:0)
UnityEngine.EventSystems.EventSystem:Update()

other relevant logs:

[Info   :Valheim Plus] Trying to load the configuration file
[Info   :Valheim Plus] Found config file at: 'C:\Program Files (x86)\Steam\steamapps\common\Valheim\BepInEx\config\valheim_plus.cfg'
[Info   :Valheim Plus] Loading config...
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [Building] Section is enabled.
[Info   :Valheim Plus] [Building] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [CraftFromChest] Section is enabled.
[Info   :Valheim Plus] [CraftFromChest] Updating range from 20 to 40
[Info   :Valheim Plus] [CraftFromChest] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [Server] Section is enabled.
[Info   :Valheim Plus] [Server] Updating serverSyncHotkeys from True to False
[Info   :Valheim Plus] [Server] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] Downloading config from: 'https://github.com/Grantapher/ValheimPlus/releases/download/0.9.11.0/valheim_plus.cfg'
[Info   :Valheim Plus] Configuration file loaded succesfully.
[Info   :Valheim Plus] Applying patches.
[Info   :Valheim Plus] Patches successfully applied.
[Info   :Valheim Plus] ValheimPlus [0.9.11.0] is up to date.
[Info   :Valheim Plus] ValheimPlus done loading.
[Info   :Valheim Plus] Version text: "Version 0.217.30 (n-17), ValheimPlus 0.9.11.0 (Grantapher Temporary)"
[Info   :Valheim Plus] Unpatching.
[Info   :Valheim Plus] Successfully unpatched.
[Info   :Valheim Plus] ServerSyncsConfig = True
[Info   :Valheim Plus] ServerSyncsHotkeys = True
[Info   :Valheim Plus] [AdvancedBuildingMode] Section is NOT enabled.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [AdvancedEditingMode] Section is NOT enabled.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [Beehive] Section is enabled.
[Info   :Valheim Plus] [Beehive] Updating autoDeposit from False to True
[Info   :Valheim Plus] [Beehive] Updating showDuration from False to True
[Info   :Valheim Plus] [Beehive] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [Building] Section is enabled.
[Info   :Valheim Plus] [Building] Updating alwaysDropResources from False to True
[Info   :Valheim Plus] [Building] Updating enableAreaRepair from False to True
[Info   :Valheim Plus] [Building] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [Inventory] Section is enabled.
[Info   :Valheim Plus] [Inventory] Updating playerInventoryRows from 4 to 5
[Info   :Valheim Plus] [Inventory] Updating woodChestColumns from 5 to 6
[Info   :Valheim Plus] [Inventory] Updating woodChestRows from 2 to 3
[Info   :Valheim Plus] [Inventory] Updating ironChestColumns from 6 to 8
[Info   :Valheim Plus] [Inventory] Updating blackmetalChestColumns from 8 to 10
[Info   :Valheim Plus] [Inventory] Updating blackmetalChestRows from 4 to 5
[Info   :Valheim Plus] [Inventory] Updating cartInventoryRows from 3 to 4
[Info   :Valheim Plus] [Inventory] Updating karveInventoryColumns from 2 to 6
[Info   :Valheim Plus] [Inventory] Updating karveInventoryRows from 2 to 3
[Info   :Valheim Plus] [Inventory] Updating longboatInventoryColumns from 8 to 10
[Info   :Valheim Plus] [Inventory] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [Fermenter] Section is enabled.
[Info   :Valheim Plus] [Fermenter] Updating fermenterItemsProduced from 4 to 6
[Info   :Valheim Plus] [Fermenter] Updating showDuration from False to True
[Info   :Valheim Plus] [Fermenter] Updating autoDeposit from False to True
[Info   :Valheim Plus] [Fermenter] Updating autoFuel from False to True
[Info   :Valheim Plus] [Fermenter] Updating ignorePrivateAreaCheck from False to True
[Info   :Valheim Plus] [Fermenter] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [FireSource] Section is enabled.
[Info   :Valheim Plus] [FireSource] Updating torches from False to True
[Info   :Valheim Plus] [FireSource] Updating fires from False to True
[Info   :Valheim Plus] [FireSource] Updating autoFuel from False to True
[Info   :Valheim Plus] [FireSource] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [Smelter] Section is enabled.
[Info   :Valheim Plus] [Smelter] Updating autoDeposit from False to True
[Info   :Valheim Plus] [Smelter] Updating autoFuel from False to True
[Info   :Valheim Plus] [Smelter] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [Furnace] Section is enabled.
[Info   :Valheim Plus] [Furnace] Updating autoDeposit from False to True
[Info   :Valheim Plus] [Furnace] Updating autoFuel from False to True
[Info   :Valheim Plus] [Furnace] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [Kiln] Section is enabled.
[Info   :Valheim Plus] [Kiln] Updating dontProcessFineWood from False to True
[Info   :Valheim Plus] [Kiln] Updating dontProcessRoundLog from False to True
[Info   :Valheim Plus] [Kiln] Updating autoDeposit from False to True
[Info   :Valheim Plus] [Kiln] Updating autoFuel from False to True
[Info   :Valheim Plus] [Kiln] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [Windmill] Section is enabled.
[Info   :Valheim Plus] [Windmill] Updating autoDeposit from False to True
[Info   :Valheim Plus] [Windmill] Updating autoFuel from False to True
[Info   :Valheim Plus] [Windmill] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [SpinningWheel] Section is enabled.
[Info   :Valheim Plus] [SpinningWheel] Updating autoDeposit from False to True
[Info   :Valheim Plus] [SpinningWheel] Updating autoFuel from False to True
[Info   :Valheim Plus] [SpinningWheel] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [EitrRefinery] Section is enabled.
[Info   :Valheim Plus] [EitrRefinery] Updating autoDeposit from False to True
[Info   :Valheim Plus] [EitrRefinery] Updating autoFuel from False to True
[Info   :Valheim Plus] [EitrRefinery] Updating autoRange from 10 to 5
[Info   :Valheim Plus] [EitrRefinery] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [Map] Section is enabled.
[Info   :Valheim Plus] [Map] Updating shareMapProgression from False to True
[Info   :Valheim Plus] [Map] Updating exploreRadius from 50 to 150
[Info   :Valheim Plus] [Map] Updating shareAllPins from False to True
[Info   :Valheim Plus] [Map] Updating displayCartsAndBoats from False to True
[Info   :Valheim Plus] [Map] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [Player] Section is enabled.
[Info   :Valheim Plus] [Player] Updating baseMaximumWeight from 300 to 400
[Info   :Valheim Plus] [Player] Updating disableCameraShake from False to True
[Info   :Valheim Plus] [Player] Updating baseUnarmedDamage from 0 to 70
[Info   :Valheim Plus] [Player] Updating autoRepair from False to True
[Info   :Valheim Plus] [Player] Updating autoEquipShield from False to True
[Info   :Valheim Plus] [Player] Updating autoUnequipShield from False to True
[Info   :Valheim Plus] [Player] Updating skipIntro from False to True
[Info   :Valheim Plus] [Player] Updating reequipItemsAfterSwimming from False to True
[Info   :Valheim Plus] [Player] Updating disableEightSecondTeleport from False to True
[Info   :Valheim Plus] [Player] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [Server] Section is enabled.
[Info   :Valheim Plus] [Server] Updating enforceMod from True to False
[Info   :Valheim Plus] [Server] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [Workbench] Section is enabled.
[Info   :Valheim Plus] [Workbench] Updating workbenchRange from 20 to 30
[Info   :Valheim Plus] [Workbench] Updating workbenchAttachmentRange from 5 to 10
[Info   :Valheim Plus] [Workbench] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [Hud] Section is enabled.
[Info   :Valheim Plus] [Hud] Updating showRequiredItems from False to True
[Info   :Valheim Plus] [Hud] Updating displayBowAmmoCounts from 0 to 1
[Info   :Valheim Plus] [Hud] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [FreePlacementRotation] Section is enabled.
[Info   :Valheim Plus] [FreePlacementRotation] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [CraftFromChest] Section is enabled.
[Info   :Valheim Plus] [CraftFromChest] Updating range from 40 to 20
[Info   :Valheim Plus] [CraftFromChest] Updating allowCraftingFromCarts from False to True
[Info   :Valheim Plus] [CraftFromChest] Updating allowCraftingFromShips from False to True
[Info   :Valheim Plus] [CraftFromChest] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] [ValheimPlus] Section is enabled.
[Info   :Valheim Plus] [ValheimPlus] Done with section.
[Info   :Valheim Plus] 
[Info   :Valheim Plus] Applying patches.
[Info   :Valheim Plus] Patches successfully applied.
[Info   :Valheim Plus] Successfully synced VPlus configuration from server.
[Info   : Unity Log] 11/15/2023 20:23:26: Setting selected recipe 6
[Info   : Unity Log] 11/15/2023 20:23:28: Setting selected recipe 6
[Info   : Unity Log] 11/15/2023 20:23:28: Item is not in this container
[Info   : Unity Log] 11/15/2023 20:23:28: Setting selected recipe 6
[Info   : Unity Log] 11/15/2023 20:23:30: Item is not in this container
[Info   : Unity Log] 11/15/2023 20:23:30: Setting selected recipe 6
VulcanTourist commented 9 months ago

I've been having an issue trying to craft Raw Fish for some time, but it hadn't occurred to me to check Player.log and it doesn't crash the game; instead, what I experience is the item appearing to be crafted and consuming the ingredient fish in the process but no FishRaw is actually produced.

Is that a different form of the same bug? I was avoiding and deferring addressing it until I happened to see this Issue. I've been sidestepping it with a console command. :-(