search

Grantapher / ValheimPlus

A HarmonyX Mod aimed at improving the gameplay and quality of life of the game Valheim.
GNU Affero General Public License v3.0
210 stars 23 forks source link

[BUG] Craft From Chest -> Check From Workbench --- Not working as expected #48

Open InsanityOnABun opened 6 months ago

InsanityOnABun commented 6 months ago

Describe the bug

This may be me misunderstanding the setting, but with Check from Workbench enabled, the reference point for checking still seems to be the player. It is also not clear if with the setting enabled the check area matches the workbench, or stays at the Chest Detection Range regardless of any differing workbench area size.

To Reproduce

Steps for the devs to reproduce the behavior:

  1. Enable "Craft From Chest Settings Enable" and "Check From Workbench".
  2. Make a workbench with a chest in its area with building materials inside. Issue is easier to reproduce with an increased workbench range, like 40m.
  3. Walk around inside the workbench area with a hammer recipe selected and see the resources become unavailable when the player is away from the chest but still inside the workbench area, implying the reference point is still the player while inside the workbench area.

Expected behavior

If a chest in a workbench area is accessible while in the workbench area, they should stay accessible no matter where the player moves to inside of the workbench area.

Troubleshooting

What steps have you taken to try to fix? None currently

Screenshots

If applicable, add screenshots to help explain your problem. N/A

Link to pastebin containing .cfg configuration if applicable: https://pastebin.com/srdt7xNZ

Additional context

Please list any other mods besides V+ that you have installed here. Add any other context about the problem here. XPortal

Grantapher commented 2 months ago

When using CraftFromChest.checkFromWorkbench, it still uses CraftFromChest.range from the workbench. Does that explain what you're seeing?