search

GranthamImperial / silicone

Automated filling of detail in reported emission scenarios
https://silicone.readthedocs.io
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

Remainder infill #108

Closed Rlamboll closed 4 years ago

Rlamboll commented 4 years ago

Pull request

Please confirm that this pull request has done the following:

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/GranthamImperial/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/GranthamImperial/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/GranthamImperial/silicone/issues/YY>`_)
znicholls commented 4 years ago

Just to make sure I have my head around things, is the idea that if you have some database with e.g. Emissions|CO2, Emissions|CO2|AFOLU and Emissions|CO2|Fossil, you can fill in all the places that are missing e.g. Emissions|CO2|AFOLU based on using the difference between Emissions|CO2 and Emissions|CO2|Fossil?

Rlamboll commented 4 years ago

Not quite, we already have a tool for that. If you have only CO2, this infills both components, but fills in one using a cruncher and the other as the difference between the two.

Rlamboll commented 4 years ago

Your suggestions are reasonable but I'd prefer to have an example where we can see that there's a more listy list of things in the components.

Rlamboll commented 4 years ago

Incidentally the build bug will apparently fix if we use the master branch of pyam rather than the last release. There should be a new release next week.

znicholls commented 4 years ago

Your suggestions are reasonable but I'd prefer to have an example where we can see that there's a more listy list of things in the components.

Nice thanks for the update!