Closed Jongy closed 1 year ago
reviewed all. just that one comment.
Waiting on https://github.com/Granulate/gprofiler/pull/621 so CI is fixed.
I need to fix the tests (some tests referenced the extra
s via the old way)
@d3dave - about this note:
Call the handler.close() method of glogger - is it needed to ensure all logs are sent back? Or does glogger have some kind of finalization?
How does glogger handle it? It seems that messages are sent by some mechanism, before the process goes down.
How does glogger handle it? It seems that messages are sent by some mechanism, before the process goes down.
logging
registers an atexit
handler that closes all stray handlers. You only need to do it if you need to flush before process exit.
Made one final change - ready to merge now
Description
Closes: https://github.com/Granulate/gprofiler/issues/525
I didn't support this feature in A/B mode as suggested in the ticket, it's much changes than I expected and it'll be hard to maintain both infras in the code.
Some changes I did as part of it:
run_id
andcycle_id
are no longer added in logging level, then omitted in local logger - I add them in glogger level.TODOs:
How Has This Been Tested?
NO_SERVER_LOG_KEY
doesn't send the message to the server.NO_SERVER_EXTRA_KEY
doesn't sendextra
s to the server.NO_SERVER_LOG_KEY
andNO_SERVER_EXTRA_KEY
are not sent to server / printed locally.NO_SERVER_LOG_KEY
are logged locallyNO_SERVER_EXTRA_KEY
are logged locally with the extras.cycle_id
passes to the backend properly--glogger-server
works