Granulate / gprofiler

gProfiler is a system-wide profiler, combining multiple sampling profilers to produce unified visualization of what your CPU is spending time on.
https://profiler.granulate.io
Apache License 2.0
746 stars 54 forks source link

Various aarch64 tests xfailed or fixed #759

Closed pfilipko1 closed 1 year ago

pfilipko1 commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots

Checklist:

Jongy commented 1 year ago

I ran it on my Aarch64 machine, these are the failures / ERRORs that remain:

================================================================================== short test summary info ===================================================================================
FAILED tests/test_perf.py::test_perf_fp_dwarf_smart[True-dwarf-native_fp] - KeyError: 554262
FAILED tests/test_perf.py::test_perf_fp_dwarf_smart[True-dwarf-native_dwarf] - KeyError: 554435
ERROR tests/test_sanity.py::test_from_container[False-nodejs-perf] - FileNotFoundError: [Errno 2] No such file or directory: 'node'
ERROR tests/test_node.py::test_nodejs_attach_maps[False-command_line0-without-flags-nodejs-attach-maps] - FileNotFoundError: [Errno 2] No such file or directory: 'node'
ERROR tests/test_node.py::test_nodejs_attach_maps_from_container[False-command_line0-without-flags-nodejs-attach-maps] - FileNotFoundError: [Errno 2] No such file or directory: 'node'
ERROR tests/test_sanity.py::test_dotnet_trace[False-dotnet] - Exception: Command ['dotnet', '/tmp/pytest-of-root/pytest-20/artifacts0/dotnet/Fibonacci/Fibonacci.dll', '--project', '/tmp/p...
ERROR tests/test_sanity.py::test_nodejs[False-nodejs] - FileNotFoundError: [Errno 2] No such file or directory: 'node'
================================================= 2 failed, 166 passed, 24 skipped, 23 xfailed, 642 warnings, 5 errors in 1780.55s (0:29:40) =================================================

Did you get them to pass in your environment?

Jongy commented 1 year ago

More work towards https://github.com/Granulate/gprofiler/issues/506

pfilipko1 commented 1 year ago

Regarding the failed tests: I've added nodejs installation, so I suggest installing it manually or running test.sh script with NO_APT_INSTALL=0 The rest occurred because of wrong conditions in xfails. Now it should be ok.

Jongy commented 1 year ago

Excellent:

=========================================================== 169 passed, 24 skipped, 27 xfailed, 654 warnings in 1841.30s (0:30:41) ===========================================================

I'll merge this PR later.