In certain non-SaaS deployments we'd like to run the server in HTTPS but with (possibly) dummy or self-signed certificates. This PR adds a simle option like curl's --insecure, wget's --no-check-certificate etc.
Tested by -
running a "simple HTTPS server" with self signed certificate per this link
Testing with curl - without -k I get curl: (60) SSL certificate problem: self-signed certificate, with -k the connection is established.
Testing with gprofiler w/o this PR - getting SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate (_ssl.c:1131)') for the get_health check.
Testing with gprofiler with this PR without --no-verify - same error as the above ^^
Testing with gprofiler with this PR with --no-verify - connection is established (and then gProfiler whines on "unexpected response").
Did the same tests for the glogger - with --no-verify I get Unsupported method ('POST') for url (because my dummy server is GET only), without --no-verify I get requests.exceptions.SSLError: HTTPSConnectionPool(host='127.0.0.1', port=3333): Max retries exceeded with url: /api/v1/logs (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate (_ssl.c:1131)'))).
Jongy
commented
1 year ago
In certain non-SaaS deployments we'd like to run the server in HTTPS but with (possibly) dummy or self-signed certificates. This PR adds a simle option like curl's
--insecure, wget's--no-check-certificateetc.Tested by -
-kI getcurl: (60) SSL certificate problem: self-signed certificate, with-kthe connection is established.SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate (_ssl.c:1131)')for theget_healthcheck.--no-verify- same error as the above ^^--no-verify- connection is established (and then gProfiler whines on "unexpected response").--no-verifyI getUnsupported method ('POST') for url(because my dummy server isGETonly), without--no-verifyI getrequests.exceptions.SSLError: HTTPSConnectionPool(host='127.0.0.1', port=3333): Max retries exceeded with url: /api/v1/logs (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate (_ssl.c:1131)'))).