Granulate / gprofiler

gProfiler is a system-wide profiler, combining multiple sampling profilers to produce unified visualization of what your CPU is spending time on.
https://profiler.granulate.io
Apache License 2.0
743 stars 54 forks source link

aarch64 executable tests #772

Closed pfilipko1 closed 1 year ago

pfilipko1 commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots

Checklist:

pfilipko1 commented 1 year ago

I had to install staticx manually as root before, but I think it is a matter of my testing environment, so I decided not to add this change to this PR. If the problem turns out to be aarch64 specific, I'll add this installation to the tests/test.sh file.

Jongy commented 1 year ago

It doesn't make sense to me that specifically the "not_privileged" tests will fail on Aarch64, this is most likely something with the environment

Jongy commented 1 year ago

I ran this on my Aarch64 server:

sudo ./tests/test.sh --executable build/aarch64/gprofiler

and got:

=========================================================== 184 passed, 26 skipped, 27 xfailed, 676 warnings in 2397.70s (0:39:57) ===========================================================

Will merge this soon

Jongy commented 1 year ago

Well, the Aarch64 executable pyperf test is marked as passing

tests/test_executable.py::test_executable[False-python-pyperf] PASSED                                                                                                                  [ 18%]

because PythonProfiler implicitly falls back to py-spy despite pyperf being requested, this needs to be fixed + the test should check for kernel + native stacks like the container test. I'll fix in a separate PR.