search

Granulate / gprofiler

gProfiler is a system-wide profiler, combining multiple sampling profilers to produce unified visualization of what your CPU is spending time on.
https://profiler.granulate.io
Apache License 2.0
743 stars 54 forks source link

Consolidate image & executable build into exe-in-image #790

Closed mpozniak95 closed 1 year ago

mpozniak95 commented 1 year ago

Related Issue

https://github.com/Granulate/gprofiler/issues/582

marcin-ol commented 1 year ago

Verified executable build and test on aarch64. Executable tests complete without issues.

marcin-ol commented 1 year ago

Building and running container tests on aarch64 results in error:

E           docker.errors.ContainerError: Command '['-v', '-d', '3', '-o', '/tmp/gprofiler', '-d', '3', '--no-java', '--no-php', '--no-ruby', '--no-nodejs', '--no-dotnet', '--python-mode=pyperf']' in image '<Image: 'gprofiler:latest'>' returned non-zero exit status 1: b'

exec /gprofiler: no such file or directory\n'

Seems that gprofiler bootstrap in container needs attention:

/ # ldd /gprofiler
        /lib/ld-linux-aarch64.so.1 (0xffffa7d5d000)
        libdl.so.2 => /lib/ld-linux-aarch64.so.1 (0xffffa7d5d000)
        libz.so.1 => /lib/libz.so.1 (0xffffa7d2c000)
        libpthread.so.0 => /lib/ld-linux-aarch64.so.1 (0xffffa7d5d000)
        libc.so.6 => /lib/ld-linux-aarch64.so.1 (0xffffa7d5d000)
Error relocating /gprofiler: __realpath_chk: symbol not found
Error relocating /gprofiler: __strdup: symbol not found
Jongy commented 1 year ago

@mpozniak95 can you please merge from master?

Jongy commented 1 year ago

I finished re-reviewing all past comments, I want to have one last go at the CI file and we'll be able to merge it.