search

Granze / react-starterify

A minimal React JS application starter kit
http://granze.github.io/react-starterify/
665 stars 71 forks source link

gulp-image breaks things #19

Closed rogerhutchings closed 8 years ago

rogerhutchings commented 8 years ago

Some of my coworkers were trying this out and came across a bug, so I thought I'd log it. On a fresh checkout, gulp-image throws an error: 

[BS] 2 files changed (main.css.map, main.css)
child_process.js:1136
  var err = this._handle.spawn(options);
                         ^
TypeError: Bad argument
    at TypeError (native)
    at ChildProcess.spawn (child_process.js:1136:26)
    at exports.spawn (child_process.js:995:9)
    at exports.execFile (child_process.js:689:15)
    at /Volumes/Projects/react-starterify/node_modules/gulp-image/optimizer.js:241:7
    at /Volumes/Projects/react-starterify/node_modules/gulp-image/node_modules/async/lib/async.js:713:13
    at iterate (/Volumes/Projects/react-starterify/node_modules/gulp-image/node_modules/async/lib/async.js:262:13)
    at /Volumes/Projects/react-starterify/node_modules/gulp-image/node_modules/async/lib/async.js:274:29
    at /Volumes/Projects/react-starterify/node_modules/gulp-image/node_modules/async/lib/async.js:44:16
    at /Volumes/Projects/react-starterify/node_modules/gulp-image/node_modules/async/lib/async.js:718:17
Granze commented 8 years ago

Hi, I was already thinking to replace this plugin because it seems that is now flagged as deprecated. I'll try to replace it this evening if I have some spare time.

Thanks for your feedback, I'll let you know ASAP.

rogerhutchings commented 8 years ago

No worries - I think they mentioned sindresorhus/gulp-imagemin working

Granze commented 8 years ago

I just moved to gulp-imagemin.

Check out the new release and let me know if it's works for you, thanks. :)

rogerhutchings commented 8 years ago

Seems legit - thanks!