search

GrapeSodaGames / Multiplayer

0 stars 0 forks source link

When a non-host player disconnects from the host, the player info is not updated to remove the disconnected player #120

Closed zaphodb2002 closed 3 months ago

zaphodb2002 commented 3 months ago

This is waiting on #108

zaphodb2002 commented 3 months ago

I've implemented the logic but it does still throw an error:

E 0:00:09:0763   player_list.gd:89 @ erase(): Condition "!pinfo" is true. Continuing.
  <C++ Source>   modules/multiplayer/scene_cache_interface.cpp:57 @ _remove_node_cache()
  <Stack Trace>  player_list.gd:89 @ erase()
                 game_state.gd:99 @ unregister_player()
                 game_state.gd:131 @ _player_disconnected()
zaphodb2002 commented 3 months ago

so pinfo above is PeerInfo, so it's trying to update the peer about the removal but it doesn't exist. Technically that's fine, though the error still bugs me.

zaphodb2002 commented 3 months ago

Still need to make the lobby ui to reflect changes