GrapesJS / components-forms

Set of form components and blocks for the GrapesJS editor
BSD 3-Clause "New" or "Revised" License
70 stars 58 forks source link

Select Component Inherits type="text" attribute from Input Component #47

Closed at-codes closed 1 year ago

at-codes commented 1 year ago

https://github.com/GrapesJS/components-forms/blob/6a63e9edb7b085790e90e98acf54accc5f4bd642/src/components.ts#L173-L174

I'm not sure what solution should be applied here. Directly extending the input component is probably not correct. Maybe there should be a common base component that input also extends with the shared attributes from all current input component children? If there isn't much shared then they probably should be separate as they don't share the same tagName.

artf commented 1 year ago

Yeah good point, I'll update it