search

GrapesJS / grapesjs

Free and Open source Web Builder Framework. Next generation tool for building templates without coding
https://grapesjs.com
BSD 3-Clause "New" or "Revised" License
22.36k stars 4.05k forks source link

[Bug] Change default font size unit to EM instead of REM. #1914

Closed lyczos closed 2 years ago

lyczos commented 5 years ago

Now in GrapesJS editor, we have some of font sizes in REM. I think they should be in EM unit because if we want to embed editor in the existing page there may be some issues with proper font size - in case when the parent font size is set to other then default size (ex. :root { font-size: 10px }). https://i.imgur.com/Vzoa5y9.png

artf commented 5 years ago

Yeah, I think you're right, would you like to create a PR?

lyczos commented 5 years ago

Yep, sure, I will do it later :)