[Suggestion] Insert a image inside link

[rgcarrasqueira]

Hi Art!

A feature that is really needed is about insert a link into a image or have a link can place a image inside a link. Today it cannot possible to do that using drag and drop feature. We have to edit the html code e insert it by hands.

Thanks.

[aryeharmon]

@rgcarrasqueira create an "a" tag component then put the image in there.

[rgcarrasqueira]

I've already tried to do that, see what is happening

[aryeharmon]

@artf i am working on a component builder, where one can save and build custom components. saving them externally or locally. is that something your interested in adding to the project once completed? For example someone wanting to add an 'a' tag component will be able to do so from the UI.

[rgcarrasqueira]

It will be great!

[aryeharmon]

@rgcarrasqueira are you sure the image is under the link component? seems to be working fine by me.

[rgcarrasqueira]

See my screencast

[aryeharmon]

@rgcarrasqueira add screenshot of layer manager link section

[rgcarrasqueira]

Ok, it follows

But I must confess we have to improve better this, because the user experience is not going well. I have some uses with not high acknowledge like us and are having some problems to deal with this use case.

[aryeharmon]

It seems to me we should set a minimum hight for links. To make sure you can drop into it.

[aryeharmon]

5px should do it

[rgcarrasqueira]

Ok, how to set it? I think it not intuitive for final user

[aryeharmon]

Edit the component code. Add style property min-height: 5px

On Aug 9, 2017 9:04 PM, "Rogério Carrasqueira" notifications@github.com wrote:

Ok, how to set it? I think it not intuitive for final user

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/artf/grapesjs/issues/223#issuecomment-321335158, or mute the thread https://github.com/notifications/unsubscribe-auth/AMVQQrSXnwQplDvAyBHwnyjuTAehG-cZks5sWfS1gaJpZM4OyHyC .

[rgcarrasqueira]

I think that is a problem, because this is inside the grapejs-preset-newsletter plugin, I have to change it and ask for a pull request. Have you got my point that means that it is not intuitive?

[aryeharmon]

So fork, and use your fork. Yes I agree with you. I am in the middle of making a builder for the component's so we will be able to edit them

On Aug 9, 2017 9:10 PM, "Rogério Carrasqueira" notifications@github.com wrote:

I think that is a problem, because this is inside the grapejs-preset-newsletter plugin, I have to change it and ask for a pull request. Have you got my point that means that it is not intuitive?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/artf/grapesjs/issues/223#issuecomment-321336765, or mute the thread https://github.com/notifications/unsubscribe-auth/AMVQQvn6KtuFgYXglxLJmhfJZ1T6yKXyks5sWfYagaJpZM4OyHyC .

[rgcarrasqueira]

I would like to help you, how to join with you in this journey?

[aryeharmon]

i created a small little dirty prototype today, i will commit tomorrow to my fork and we can implement it properly.

[artf]

@aryeharmon would be awesome to see your work as a plugin :) @rgcarrasqueira #88 the Link Block was made for this purpose

[rgcarrasqueira]

Art, sorry I did not understand why you closed this ticket. I think that this matter still remains.

[artf]

Sorry @rgcarrasqueira but I think the #88 explains pretty much well the same situation. You can't attach links on the Image Component but there is 'Link Block'. Without the link block, you should probably create a new component type, best as a plugin

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.