GrapesJS / grapesjs

Free and Open source Web Builder Framework. Next generation tool for building templates without coding
https://grapesjs.com
BSD 3-Clause "New" or "Revised" License
22.38k stars 4.06k forks source link

Delete icon functionality in the toolbar for the link is not working #2335

Closed logeshkrishna0 closed 4 years ago

logeshkrishna0 commented 4 years ago

WARNING

READ and FOLLOW next 5 steps, then REMOVE them before posting the issue

  1. Follow CONTRIBUTING Guidelines https://github.com/artf/grapesjs/blob/master/CONTRIBUTING.md
  2. Use the GitHub Issues EXCLUSIVELY for BUGS, FEATURE REQUESTS or QUESTIONS. Prefix the title of the issue with its context, eg. [Bug]: ....
  3. Do a quick SEARCH first, to see if someone else didn't open the same issue
  4. DON'T ASK to create examples/code for you, read DOCS and APIs first, then you can post what you have tried (we'd like to see your code) and what you're unable to achieve
  5. All relative statements/questions have to be filled/answered, otherwise, the issue might be CLOSED

You're submitting a BUG

  1. Are you using the latest release (older versions are NOT supported)?
    1. If you're not sure, type grapesjs.version in console and press ENTER
  2. Are you facing the bug with your local copy of GrapesJS or with the current demo?
  3. If a local copy
    1. Indicate all informations about your OS, browser and GrapesJS version.
    2. Are you able to reproduce the bug from the demo?
  4. What is the expected behavior?
  5. What happens instead?
  6. If you're able to reproduce the bug indicate all the necessary steps
  7. Attach screenshots (using KAP/LICEcap), screencasts or live demo
    1. JSFiddle Starter template https://jsfiddle.net/szLp8h4n
    2. CodeSandbox Starter template https://codesandbox.io/s/1r0w2pk1vl

You're submitting a FEATURE REQUEST

  1. Be sure to work on the latest version, as the feature might be already there
  2. Keep in mind that the feature should be considered valid to use for everyone, not only for your case
logeshkrishna0 commented 4 years ago

Screen Shot 2019-10-15 at 9 15 27 AM here is the exact picture of the delete icon which is not working The above delete icon is not working for the anchor tag but when i add span (by inspect) to the tag it will be deleted. so i want the thing to be shorted out. could you please sort it out

hellocaio commented 4 years ago

It is working for me... 🤔

logeshkrishna0 commented 4 years ago

But It never worked for me and I just made code by remove functionality for the link as 'tbl-delete' @ColdTuna

hellocaio commented 4 years ago

The delete icon shows up but when you click the link is not removed, correct?

Are you using the latest version of GrapesJS? What browser are you using? Are you changing any properties in the model of the default component link? Post how you are initializing the editor if you can.

logeshkrishna0 commented 4 years ago

const content = `${textBefore}<a href="${url}" target="_parent" class="link">${name}</a>${textAfter}`; selectedComponentWrapper.components(content); This how i create the anchor tag in my editor and i place it as components

I am using the older version of grapejs Tried in all browser except the IE @ColdTuna

artf commented 4 years ago

I am using the older version of grapejs

Well, it was one of the old issues... you have to update your version