BUG: Minor issue in webpage demo Tooltip

GrapesJS / grapesjs

Free and Open source Web Builder Framework. Next generation tool for building templates without coding

https://grapesjs.com

BSD 3-Clause "New" or "Revised" License

22.38k stars 4.06k forks source link

BUG: Minor issue in webpage demo Tooltip #2971

Closed gunslingor closed 4 years ago

gunslingor commented 4 years ago

webpage demo

Summary: el.setAttribute('title', ''); fails for view panel buttons only (not options panel buttons).

Symptom: You can see the mouse over on the view buttons, they all start with "Open yada yada", the word open should be removed per the array (e.g. ['open-sm', 'Style Manager']).

Cause: Suspect something isn't happening in the right order, probably due to the presets again.

would be nice if orderings were inherently taken care of with a preset =).

artf commented 4 years ago

Can elaborate better on how to reproduce the issue, please?

gunslingor commented 4 years ago

Go here: https://grapesjs.com/demo.html
Hover over any view icons, notice the tooltip starts with Open
If you look a the javascript, in the same area you set the other tooltips your changing these as well to show the name without the word "Open"; I tried to change them to random things but it never took. Not sure if its a preset issue.

Maybe not a big deal since I hope to start making my own plugins soon. I'm just diving deep into grapejs so figured you might wanna know.

artf commented 4 years ago

Those tooltips are made for the demo purpose, this has nothing to do with the core library... Anyway, the value shown is taken from data-tooltip and not title.