GrapesJS / grapesjs

Free and Open source Web Builder Framework. Next generation tool for building templates without coding
https://grapesjs.com
BSD 3-Clause "New" or "Revised" License
22.36k stars 4.05k forks source link

BUG: with buttons #3205

Closed OleksandrNeroda closed 3 years ago

OleksandrNeroda commented 3 years ago

https://grapesjs.com/demo.html

when i edit the button text to 'test' after reload the result: image

OleksandrNeroda commented 3 years ago

@artf maybe you can help with this?

fzerman commented 3 years ago

This demo saves your changes to your local storage of the browser. If you didn't save, it is normal. Try to save or run editor.store() in console.

OleksandrNeroda commented 3 years ago

@Swindler36 in my project i do not use the local storage only everything is saved to the database, but the problem the same. I don't think that is a local storage problem.

fzerman commented 3 years ago

I wanted to say that if you didn't save your changes to your storage, after the page refresh it loads older save. Therefore, you can try to save your changes before reloading.

OleksandrNeroda commented 3 years ago

ok but that's weird. Why is this problem only for the button? You tried to recreate it on https://grapesjs.com/demo.html old and new values are concatenated after refreshing

OleksandrNeroda commented 3 years ago

anyone have any ideas?

artf commented 3 years ago

Fixed with the new release of the form plugin https://github.com/artf/grapesjs-plugin-forms/releases/tag/v2.0.1

OleksandrNeroda commented 3 years ago

@artf However, from what I can see in the version v0.16.34 at https://grapesjs.com/demo.html it is still possible to reproduce this bug.

artf commented 3 years ago

sorry @OleksandrNeroda I'm too lazy to update also the demo with the new version 😂 PR is welcome

dan-castillo commented 2 years ago

Ignore this as I opened a new issue #3940 as I think its happening with the latest version as well believe this is still happening with version 0.17.28 see the attached image

All I did has clicked on the demo link in this repo - scrolled down to the contact us and changed the text for the button - although it changed it on the canvas/editor - the change does not reflect in the code when you hit view code -

If it helps I tried this in Grapedrop by adding a form control to a page and changed the button text and it worked as expected

image