GrapesJS / grapesjs

Free and Open source Web Builder Framework. Next generation tool for building templates without coding
https://grapesjs.com
BSD 3-Clause "New" or "Revised" License
22.38k stars 4.05k forks source link

BUG: id are added to <img/> on double click on it #3272

Closed ThomasPof closed 3 years ago

ThomasPof commented 3 years ago

Version:

0.16.37

Are you able to reproduce the bug from the demo?

[X] Yes [ ] No

What is the expected behavior?

It's about the GrapesJS-mjml plugin : this syntax doesn't accept id's on elements. But AssetsManager add ids to image elements. I would like to not add id attributes to tags

Steps to reproduce

You can find the GrapesJS-mjml issue here : https://github.com/artf/grapesjs-mjml/issues/179

ThomasPof commented 3 years ago

The id seems to be added way before opening the asset manager :

ThomasPof commented 3 years ago

Found a clue in /Users/thomaspopoff/Sites/grapesjs/src/code_manager/model/HtmlGenerator.js line 10, the opts.cleanId is always undefined. I don't know how to set it to true to remove auto-generated ids

ThomasPof commented 3 years ago

Ok sorry for all my self-talk : there is an option opts.cleanId inside getHtml() function you can configure to remove auto-generated ids...

artf commented 3 years ago

Well, that option was actually released today https://github.com/artf/grapesjs/releases/tag/v0.16.41 😅