search

GrapesJS / grapesjs

Free and Open source Web Builder Framework. Next generation tool for building templates without coding
https://grapesjs.com
BSD 3-Clause "New" or "Revised" License
22.38k stars 4.06k forks source link

Custom plugins does not overrides default commands #355

Closed arthuralmeidap closed 7 years ago

arthuralmeidap commented 7 years ago

@artf , Until versions 0.9.x , GrapesJS loads all it's internal's modules before all the plugins are initialized. Since from version 0.10.2 you added a new module initialization after the plugins initialization. You can see it here: https://github.com/artf/grapesjs/blob/v0.10.2/src/grapesjs/index.js#L73 This behaviour has some side-effects, for example on grapesjs-preset-newsletter plugin because it tries to override the command 'export-template' but, when you initialized the modules after the plugins, this command is overridden again with the default command.

arthuralmeidap commented 7 years ago

I've created a PR with a fix to this behavior. Take a look here: https://github.com/artf/grapesjs/pull/356

lock[bot] commented 5 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.