GrapesJS / grapesjs

Free and Open source Web Builder Framework. Next generation tool for building templates without coding
https://grapesjs.com
BSD 3-Clause "New" or "Revised" License
22.36k stars 4.05k forks source link

BUG: component.remove() in 'component:mount' does not remove the rendered view #4136

Closed m-jojo-s closed 2 years ago

m-jojo-s commented 2 years ago

GrapesJS version

What browser are you using?

Chrome Version 98.0.4758.80 (Official Build) (arm64)

Reproducible demo link

https://jsfiddle.net/Lsjhxczp/10/

Describe the bug

How to reproduce the bug?

  1. Setup the component:mount hook to remove mounted component
  2. Add a new block/component

What is the expected behavior? The new component gets removed, both model and view.

What is the current behavior? Only the model is removed, view stays in place and isn't re-rendered after removal.

If is necessary to execute some code in order to reproduce the bug, paste it here below:

editor.on('component:mount', component => {
    if (component.is('image')) {
      component.remove();
    }
});

// the following has no effect
/* editor.on('component:create', component => {
    if (component.is('image')) {
      component.remove();
    }
}); */

Code of Conduct

artf commented 2 years ago

Yeah, the problem here is the DOM node is created but not yet appended to the parent. You can defer the removal via setTimeout but that will still trigger the image activation. Probably I'll move that event once the node is appended.