search

GrapesJS / grapesjs

Free and Open source Web Builder Framework. Next generation tool for building templates without coding
https://grapesjs.com
BSD 3-Clause "New" or "Revised" License
22.37k stars 4.05k forks source link

BUG: selector:remove event does not exist #4356

Closed Justin8303 closed 2 years ago

Justin8303 commented 2 years ago

GrapesJS version

What browser are you using?

Chrome 101

Reproducible demo link

https://jsfiddle.net/sdrf72wx/1/

Describe the bug

How to reproduce the bug?

  1. execute the code below on the initialization of the editor
  2. add and remove a selector of a component
  3. Look at the console output

What is the expected behavior? If a component selector is removed, it should print the selector to the console.

What is the current behavior? There is no console message, if the selector is removed, so the "selector:remove" event is not firing. Also, the "selector" event only catches "selector:add" and "selector:update" but NOT "selector:remove" but in the event section of the Selector Manager they are available.

If it is necessary to execute some code in order to reproduce the bug, paste it here below:

editor.on("selector:remove", (data) => {
    console.log(data)
})

Code of Conduct

artf commented 2 years ago

Hi @Justin8303 selector:remove refers to the global container of selectors so it's only triggered when the selector is actually removed from the global collection and not from the component. When you remove the selector from the component, it still exists as it might also be used somewhere else. If you need to track component classes changes, I'd suggest using the component:update:classes event