GrapesJS / grapesjs

Free and Open source Web Builder Framework. Next generation tool for building templates without coding
https://grapesjs.com
BSD 3-Clause "New" or "Revised" License
22.36k stars 4.05k forks source link

BUG: Error: node_modules/grapesjs/dist/index.d.ts:12551:2 - error TS1005: '?' expected. 12551 }> ? C : {}) | undefined) => (editor: Editor) => void; ~ Error: node_modules/grapesjs/dist/index.d.ts:12558:3 - error TS1005: '?' expected. 12558 }> ? C : {}) | undefined) => (editor: Editor) => void; #5377

Closed Akkiiiiiii closed 1 year ago

Akkiiiiiii commented 1 year ago

GrapesJS version

What browser are you using?

Chrome

Describe the bug

After Upgrade new version 0.21.5 getting these errors . we are working with grapesjs + angular, grapesjs v 0.21.5 not available in both jsFiddle and codeSandbox right now so i'm putting a dummy link. please help us out.

Code of Conduct

Akkiiiiiii commented 1 year ago

@artf can you please check this one

THEWebDegenerate commented 1 year ago

I use safari and chrome

On Tue, Sep 12, 2023 at 10:52 PM Akshay jangid @.***> wrote:

@artf https://github.com/artf can you please check this one

— Reply to this email directly, view it on GitHub https://github.com/GrapesJS/grapesjs/issues/5377#issuecomment-1716989704, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANQ6NOR2BYRPPRYFJF5ZGLDX2FC3TANCNFSM6AAAAAA4TBTVBU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

filipRisteski commented 1 year ago

+1 after upgrade

artf commented 1 year ago

I don't see any issue for those lines on my side (typescript@5.2.2)

Screenshot 2023-09-16 at 11 12 05

I guess that might related to your local typescript version, otherwise "skipLibCheck": true might also be a good workaround.