search

GrapesJS / grapesjs

Free and Open source Web Builder Framework. Next generation tool for building templates without coding
https://grapesjs.com
BSD 3-Clause "New" or "Revised" License
22.36k stars 4.05k forks source link

BUG: Commands.runCommand not working for built in command #5683

Closed JonathanRiche closed 7 months ago

JonathanRiche commented 7 months ago

GrapesJS version

What browser are you using?

chrom v121

Reproducible demo link

https://grapesjs.com/demo.html

Describe the bug

How to reproduce the bug? 1.Go the the graepesjs.com/demo page open up the console and use the global editor object run the editor.runCommand( 'sw-visibility') method - built in grid lines And the command does not run even though its been set on the panel, I've had this setup in my project and recently upgraded from 0.20.3 to the latest v0.21.8 and noticed the editor.runCommand no longer works even when trying editor.runCommand( 'sw-visibility',{force:true}) no luck

What is the expected behavior? The command toggles the sw-visiibility command like the panel/button similar to the grapejs demo

What is the current behavior? toggle does not work programmatically anymore

If is necessary to execute some code in order to reproduce the bug, paste it here below:

editor.runCommand( 'sw-visibility')

Code of Conduct

JonathanRiche commented 7 months ago

needed to run visualEditor.stopCommand('sw-visibility') first not sure if this is new runCommand used to toggle before with having to run stop