search

GrapesJS / grapesjs

Free and Open source Web Builder Framework. Next generation tool for building templates without coding
https://grapesjs.com
BSD 3-Clause "New" or "Revised" License
20.78k stars 3.9k forks source link

BUG: Cannot edit component content even with editable property set to true #5888

Closed Dobby85 closed 2 months ago

Dobby85 commented 2 months ago

GrapesJS version

What browser are you using?

Chrome V124

Reproducible demo link

https://jsfiddle.net/ycvz2gno/7/

Describe the bug

How to reproduce the bug?

  1. Put a text block in the canvas
  2. Double click on the content inside the text block
  3. The content cannot be edited

What is the expected behavior? It should open the RTE so we could edit the text inside the component

What is the current behavior? Nothing happened, the component cannot be edited



### Code of Conduct

- [X] I agree to follow this project's Code of Conduct
Dobby85 commented 2 months ago

By looking into the code, I saw that to get the RTE functionnality, our new component has to extend ComponentTextView. My initial issue was that I did something like :

editor.DomComponents.addType('textBlock', {
    isComponent: el => el.tagName === 'DIV',
    extend: 'text',
    model: {
      defaults: {
        editable: true,
        tagName: 'div',
        icon: 'ICON',
        components: `Some text`
      }
    },
    extendView: 'baseStructure'
  })

And it tooks the view of my baseStructure and not the text component. I will try to find a workaround for that by don't extending my baseStructure view.