BUG: Too much recursion

[jlafosse]

GrapesJS version

• [X] I confirm to use the latest version of GrapesJS

What browser are you using?

Firefox 131.0.2

Reproducible demo link

https://grapesjs.com/demo-newsletter-editor.html

Describe the bug

How to reproduce the bug?

1. Go to the grapesjs demo, then import the following html:

<div class="foobar">
    <img data-gjs-locked="true" width="500" src="https://cdn.pixabay.com/photo/2021/12/16/15/26/forest-6874717_1280.jpg">
</div>

2. Open your browser console.
3. Rapidly click on the image multiple times.

What is the expected behavior? Should work without errors.

What is the current behavior? This causes a recursion error in FireFox. Chrome does not seem to be affected by this issue. I am testing this on OSX 13.6.9 and I have included a short screen recording.

Uncaught InternalError: too much recursion
    getList Component.ts:1931
    ensureInList Component.ts:1866
    ensureInList Component.ts:1880
    Ke Underscore
    Backbone Backbone
    ensureInList Component.ts:1880
    ensureInList Component.ts:1880
    Ke Underscore
    Backbone Backbone
    ensureInList Component.ts:1880
    ensureInList Component.ts:1880

My suspicion is that the issue is coming from the following function: https://github.com/GrapesJS/grapesjs/blob/dev/packages/core/src/dom_components/model/Components.ts#L373

Thanks.

https://github.com/user-attachments/assets/54b6c40f-d435-41f9-a09f-47450f01523e

Code of Conduct

• [X] I agree to follow this project's Code of Conduct

[artf]

Hey @jlafosse thanks for the report.

I'd not expect that issue with the latest version:

Can you try to check again, please?

[jlafosse]

Indeed, that appears to have fixed the issue! Thank you!

[artf]

🙌 closing then, thanks 🙇‍♂️