Closed AliErdin closed 5 years ago
Hi, @AliErdin
just noticed same kind of issue. When changing font size or color, the new size or color is only available if i duplicate the column.
Something got just broken ..
Yeah same with line-height, align, padding, height/width and other style manager settings. Theres some big bug atm.
There's been a change in grapesjs 0.15.8 that now defaults the config.avoidInlineStyle
to being true. Now if you set this back to being false, all the settings start working again. For example:
var editor = grapesjs.init({
fromElement: true,
container : '#gjs',
avoidInlineStyle : false,
plugins: ['grapesjs-mjml'],
pluginsOpts: {
'grapesjs-mjml': {/* ...options */}
}
});
There is a longer term question in play though that the release notes state the support for this configuration will be dropped. @artf it seems that this configuration is required for the grapesjs-mjml plugin so what needs to be done to ensure future compatibility?
Thanks @Clint-Chester for pointing out the reason. Actually is true, I'd like to remove that option because from web point-of-view is useless but in this case, not having a well-defined API for a custom renderer this option is still crucial (indeed I'll force it in the next release, it doesn't work without). Now I'll keep it in mind before removing that option completely from the code.
ps. online demo updated with the option for now.
I believe the avoidInlineStyles solution is only partial. Do this: paste this MJML to import into the canvas:
I'd look at opening it up as a separate issue @kickbk as like you said it's dropping it on the import, where as the issue you commented on here was around settings not sticking when using the Style Manager.
@Clint-Chester sorry, thought it was somehow related. Created https://github.com/artf/grapesjs-mjml/issues/147
avoidInlineStyle : false,
:+1:
I can't change the font color via style manager / typography / font color